fix: serviceName and portName must correspond to port binding #1226
+17
−11
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
code-quality tests fails are not related to the changes in code. The first one is IPV6 address against IPV4, others are something with cryptography. |
|
@w666 -- could you force checks run for this? |
|
#1337 adds support for this. It was not a bug, it just was not implemented. Closing. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Soap server code makes an assumption that url may not match the port binding. In this case the first port is used. At the same time WSDL can have multiply services and ports and therefore not only the first port binding should be taken but also first port name and first service name. Without this patch the first port binding is used and the last serviceName and portName. With this patch applied port binding corresponds correct serviceName and portName.